Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add scaffold-ui tests #2913

Merged
merged 5 commits into from
Sep 30, 2024
Merged

chore: add scaffold-ui tests #2913

merged 5 commits into from
Sep 30, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Sep 24, 2024

Description

  • Adds tests for scaffold-ui utilities

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • [] Approver of this PR confirms that the changes are tested on the preview link

@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 30, 2024 5:10pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 30, 2024 5:10pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 85bae5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 246.39999999999998% 4242 / 18753
🔵 Statements 246.39999999999998% 4242 / 18753
🔵 Functions 261.16% 328 / 999
🔵 Branches 312.6% 592 / 1264
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/partials/w3m-all-wallets-list/index.ts 0% 0% 0% 0% 1-8, 11, 13-15, 18, 20, 23, 25, 27, 29, 31-40, 42-45, 47-50, 53-54, 56-57, 62-63, 66, 69-85, 87-90, 92-93, 95-97, 99-100, 102-103, 106-107, 109-115, 117-119, 121-123, 125-126, 128-141, 143-151
packages/scaffold-ui/src/partials/w3m-all-wallets-search/index.ts 0% 0% 0% 0% 1-7, 9-11, 14, 17, 19, 22-23, 25-28, 31-38, 40-42, 44-45, 57, 59, 61, 66-67, 69-70, 73, 76, 78-86
packages/scaffold-ui/src/utils/WalletUtil.ts 94.73% 81.81% 100% 94.73% 17, 65-66
Generated in workflow #6456 for commit 85bae5a by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0.157 0.065

Current Size

Name Size (kb) Gzip (kb)
assets/index-ztd7r6f1.js 1880.105 536.857
assets/index.js 9.63 3.16
assets/index2.js 11.599 3.218
assets/w3m-modal.js 7.452 2.627
assets/noble-curves.js 31.941 12.777
assets/2.21.4_bufferutil.js 2.789 1.326
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.284
assets/hooks.module.js 74.286 25.523
index.html 0.329 0.235
Total Size 2424.775 702.122

Base Size

Name Size (kb) Gzip (kb)
assets/index-ztd7r6f1.js 1880.105 536.857
assets/index.js 9.63 3.16
assets/index2.js 11.599 3.218
assets/w3m-modal.js 7.452 2.627
assets/noble-curves.js 31.941 12.777
assets/2.21.4_bufferutil.js 2.789 1.326
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.284
assets/hooks.module.js 74.443 25.588
index.html 0.329 0.235
Total Size 2424.932 702.187

magiziz
magiziz approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@magiziz magiziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomiir tomiir merged commit 1414385 into main Sep 30, 2024
17 checks passed
@tomiir tomiir deleted the chore/utils-tests branch September 30, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enesozturk enesozturk enesozturk left review comments

@magiziz magiziz magiziz approved these changes

@svenvoskamp svenvoskamp Awaiting requested review from svenvoskamp

@zoruka zoruka Awaiting requested review from zoruka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomiir @enesozturk @magiziz